Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: removed unnecessary credentials from ci #936

Merged
merged 8 commits into from
Aug 9, 2023
Merged

ci: removed unnecessary credentials from ci #936

merged 8 commits into from
Aug 9, 2023

Conversation

CharlieMc0
Copy link
Member

@CharlieMc0 CharlieMc0 commented Aug 9, 2023 •
edited
Loading

Description

There are some dependencies on secrets that are no longer needed but their existence blocked the workflow from running for PRs created form outside forks.

Closes: This will allow contributions from outside collaborators to work correctly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@CharlieMc0 CharlieMc0 self-assigned this Aug 9, 2023
@CharlieMc0 CharlieMc0 changed the title ci: removed unnecessary credentials form ci: removed unnecessary credentials from ci Aug 9, 2023
@CharlieMc0 CharlieMc0 added the ci Changes to CI pipeline or github actions label Aug 9, 2023
@CharlieMc0 CharlieMc0 temporarily deployed to athens2 August 9, 2023 14:00 — with GitHub Actions Inactive
lumtis
lumtis approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm curious why if: (! startsWith(github.ref, 'refs/tags/')) || (! startsWith(github.ref, 'refs/heads/develop') ) is commented out at multiple places?

@CharlieMc0
Copy link
Member Author

I had to create a PR to test the CI even though it wasn't ready for review yet. So you saw a WIP. They were only commented out so I could test the whole workflow without creating a new tag/release.

It is ready now!

@lumtis lumtis mentioned this pull request Aug 9, 2023
Closed
11 tasks
@CharlieMc0 CharlieMc0 merged commit b7dfadf into develop Aug 9, 2023
15 checks passed
@CharlieMc0 CharlieMc0 deleted the ci-remove-unused-creds branch August 9, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@ws4charlie ws4charlie ws4charlie approved these changes

@lumtis lumtis lumtis approved these changes

@kingpinXD kingpinXD Awaiting requested review from kingpinXD

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@CharlieMc0 CharlieMc0

Labels
ci Changes to CI pipeline or github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharlieMc0 @lumtis @ws4charlie @brewmaster012